Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable benchmarks #120

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Stable benchmarks #120

merged 2 commits into from
Jul 9, 2024

Conversation

marco6
Copy link
Collaborator

@marco6 marco6 commented Jul 8, 2024

This PR makes each benchmark run at least 7 times (which in general is the minimum amount of repetitions to compute p with benchstat tool).

Given that this will increase again bench time, I removed the building of dqlite and used the PPA instead, so that some of the time spent there can be saved.

@marco6
Copy link
Collaborator Author

marco6 commented Jul 8, 2024

Draft as depends on #117

@marco6
Copy link
Collaborator Author

marco6 commented Jul 9, 2024

Marking as ready since #117 was merged.

@marco6 marco6 marked this pull request as ready for review July 9, 2024 07:16
@marco6 marco6 requested a review from a team as a code owner July 9, 2024 07:16
@marco6 marco6 requested a review from bschimke95 July 9, 2024 07:16
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marco6 marco6 merged commit 092e35e into canonical:master Jul 9, 2024
6 of 7 checks passed
@marco6 marco6 deleted the stable-benchmarks branch July 9, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants